[PATCH v2 2/4] windows.media.speech: Implement IInstalledVoicesStatic stub.

Jacek Caban jacek at codeweavers.com
Fri Mar 5 15:15:05 CST 2021


On 05.03.2021 22:06, Zebediah Figura (she/her) wrote:
>
> Well, it's one less allocation, which is always nice.
>
> Definitely the interface should be visually separated in the 
> windows_media_speech structure, though.


Again, it's a static object so no allocation is needed at all. And even 
if it was, it sounds to me like encouraging micro-optimization.


>> BTW, as long as those object implement ref counting, they are not 
>> exactly immutable.
>
> True, but I at least hope we're past the point where programs abuse 
> COM refcounting all the time, and that nonsense can be confined to 
> things like ddraw and dmusic ;-)


Yup, that's why we usually don't need to replicate the exact native ref 
count behaviour. That doesn't mean we shouldn't do it right.


Jacek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210305/3e2932c9/attachment.htm>


More information about the wine-devel mailing list