[PATCH 1/3] user32: Implement SendInput size parameter check.

[Rémi Bernon]

On 3/9/21 6:27 PM, Rémi Bernon wrote:
> On 3/9/21 4:07 PM, Marvin wrote:
>> Hi,
>>
>> While running your changed tests, I think I found new failures.
>> Being a bot and all I'm not very good at pattern recognition, so I 
>> might be
>> wrong, but could you please double-check?
>>
>> Full results can be found at:
>> https://testbot.winehq.org/JobDetails.pl?Key=86705
>>
>> Your paranoid android.
>>
>>
>> === w2008s64 (32 bit report) ===
>>
>> user32:
>> input.c:4144: Test failed: SendInput returned 0, error 0x57
>>
>> === w7u_2qxl (32 bit report) ===
>>
>> user32:
>> input.c:756: Test failed:  0 (a4/0): 00 from 00 -> 80 unexpected
>>
>> === w864 (32 bit report) ===
>>
>> user32:
>> input.c:4144: Test failed: SendInput returned 0, error 0x57
>>
>> === w1064v1507 (32 bit report) ===
>>
>> user32:
>> input.c:4144: Test failed: SendInput returned 0, error 0x57
>>
>> === w1064v1809 (32 bit report) ===
>>
>> user32:
>> input.c:4144: Test failed: SendInput returned 0, error 0x57
>>
>> === w1064 (32 bit report) ===
>>
>> user32:
>> input.c:4144: Test failed: SendInput returned 0, error 0x57
>>
>> === w10pro64 (32 bit report) ===
>>
>> user32:
>> input.c:4144: Test failed: SendInput returned 0, error 0x57
>>
>> === wvistau64 (64 bit report) ===
>>
>> user32:
>> input.c:756: Test failed:  0 (a4/0): 00 from 00 -> 80 unexpected
>> input.c:756: Test failed:  0 (a4/0): 01 from 01 -> 00 unexpected
>> input.c:756: Test failed:  0 (a4/0): 11 from 01 -> 00 unexpected
>> input.c:756: Test failed:  0 (a4/0): a2 from 01 -> 00 unexpected
>>
>> === w1064v1809 (64 bit report) ===
>>
>> user32:
>> input.c:1432: Test failed: Wrong new pos: (150,150)
>>
>> === w10pro64_ar (64 bit report) ===
>>
>> user32:
>> input.c:3240: Test failed: expected WM_LBUTTONDOWN message
>> input.c:3241: Test failed: expected WM_LBUTTONUP message
>> input.c:3268: Test failed: expected WM_NCHITTEST message
>> input.c:3269: Test failed: expected WM_RBUTTONDOWN message
>> input.c:3270: Test failed: expected WM_RBUTTONUP message
>> input.c:3299: Test failed: expected WM_LBUTTONDOWN message
>> input.c:3300: Test failed: expected WM_LBUTTONUP message
>> input.c:3353: Test failed: expected loop with WM_NCHITTEST messages
>> input.c:3406: Test failed: expected WM_LBUTTONDOWN message
>> input.c:3407: Test failed: expected WM_LBUTTONUP message
>>
>> === w10pro64_he (64 bit report) ===
>>
>> user32:
>> input.c:3240: Test failed: expected WM_LBUTTONDOWN message
>> input.c:3241: Test failed: expected WM_LBUTTONUP message
>> input.c:3268: Test failed: expected WM_NCHITTEST message
>> input.c:3269: Test failed: expected WM_RBUTTONDOWN message
>> input.c:3270: Test failed: expected WM_RBUTTONUP message
>> input.c:3299: Test failed: expected WM_LBUTTONDOWN message
>> input.c:3300: Test failed: expected WM_LBUTTONUP message
>> input.c:3353: Test failed: expected loop with WM_NCHITTEST messages
>> input.c:3406: Test failed: expected WM_LBUTTONDOWN message
>> input.c:3407: Test failed: expected WM_LBUTTONUP message
>>
>> === debiant2 (32 bit report) ===
>>
>> user32:
>> win.c:3079: Test succeeded inside todo block: Focus should be on child 
>> 000800FE, not 000800FE
>>
>> === debiant2 (32 bit Chinese:China report) ===
>>
>> user32:
>> win.c:3079: Test succeeded inside todo block: Focus should be on child 
>> 000800FE, not 000800FE
>>
>> === debiant2 (32 bit WoW report) ===
>>
>> user32:
>> win.c:3079: Test succeeded inside todo block: Focus should be on child 
>> 000800FE, not 000800FE
>>
>> === debiant2 (64 bit WoW report) ===
>>
>> user32:
>> win.c:3079: Test succeeded inside todo block: Focus should be on child 
>> 000800FE, not 000800FE
>> win.c:10097: Test failed: Expected foreground window 0, got 00E10102
>> win.c:10103: Test failed: Expected foreground window 000E013E, got 
>> 00E10102
>>
> 
> I'm probably stupid and missed something here? I really thought I had 
> checked these test results before sending them...

Ah yeah WoW64 gives ERROR_INVALID_PARAMETER instead of ERROR_NOACCESS 
when passing NULL, great.
-- 
Rémi Bernon <rbernon at codeweavers.com>