[PATCH v2 2/2] jscript: Use default object prototype if it's null.

Jacek Caban jacek at codeweavers.com
Wed Mar 10 14:14:08 CST 2021


Hi Gabriel,

On 05.03.2021 17:59, Gabriel Ivăncescu wrote:
> +        else if(SUCCEEDED(find_prop_name(ctx->object_constr, string_hash(L"prototype"), L"prototype", &prop)) &&
> +                prop && prop->type != PROP_DELETED && SUCCEEDED(prop_get(constr, prop, &val)) && is_object_instance(val))
> +            prot = iface_to_jsdisp(get_object(val));


We should probably just store object prototype in script_ctx_t. Note 
that if some weird script replaces Object.prototype value, we still want 
to use builtin one instead.


Also some tests using different prototype types would be nice, for 
example you may try to set it to number, boolean and a string.


Thanks,

Jacek




More information about the wine-devel mailing list