[PATCH 5/5] wined3d: Don't pass the whole context to wined3d_ffp_get_vs_settings().
Henri Verbeet
hverbeet at gmail.com
Thu Mar 11 05:52:36 CST 2021
On Wed, 10 Mar 2021 at 20:50, Matteo Bruni <mbruni at codeweavers.com> wrote:
> -void wined3d_ffp_get_vs_settings(const struct wined3d_context *context,
> - const struct wined3d_state *state, struct wined3d_ffp_vs_settings *settings)
> +void wined3d_ffp_get_vs_settings(const struct wined3d_stream_info *si,
> + const struct wined3d_d3d_info *d3d_info, const struct wined3d_state *state,
> + struct wined3d_ffp_vs_settings *settings)
> {
> enum wined3d_material_color_source diffuse_source, emissive_source, ambient_source, specular_source;
> - const struct wined3d_stream_info *si = &context->stream_info;
> - const struct wined3d_d3d_info *d3d_info = context->d3d_info;
> unsigned int coord_idx, i;
>
I suppose that's fine, but I don't think it's quite obvious why we
care, or why it's an improvement.
More information about the wine-devel
mailing list