[PATCH 3/7] windows.media.speech/tests: Add interface query tests.

Francois Gouget fgouget at codeweavers.com
Mon Mar 15 13:48:32 CDT 2021


On Fri, 12 Mar 2021, Rémi Bernon wrote:
[...]
> > === debiant2 (32 bit French report) ===
> > 
> > Report validation errors:
> > The report seems to have been truncated
> > 
> 
> So it looks like that Marvin still fails to pick the new DLL when it runs from
> the ML, but it worked fine when I submitted the patch manually, as in:
> 
>   https://testbot.winehq.org/JobDetails.pl?Key=86929

For manual jobs one can pass custom arguments to the test executable. 
But WineTest.exe does not support passing arbitrary arguments to a 
specific test executable.

So when the WineTest.pl script (which is responsible for doing the build 
and running the tests on Wine VMs) receives extra arguments is always 
runs the test using TestLauncher which does not have the bug that 
WineTest.exe has.

But when receiving a patch through the mailing list there is no custom 
argument. Furthermore there may be more than one test to run. So in that 
case, rather than running TestLauncher.exe multiple times, the 
WineTest.pl script invokes WineTest.exe with arguments specifying which 
tests to run.

So after simplifying the commands a bit, for job 86929 we had:
WineTest.pl --testpatch win32:wow32:wow64 patch.diff windows.media.speech statics
 "windows.media.speech statics" are the extra args which, in this case, 
 could be handled by passing "windows.media.speech:statics" to 
 WineTest.exe. But 'statics' could have been anything really.

 -> wine TestLauncher64.exe -t 120 windows.media.speech_test.exe statics

And for job 86934:
WineTest.pl --testpatch win32 patch.diff
 No extra argument.

 -> wine winetest.exe -c -o win32.report -t do.not.submit setupapi windows.media.speech


That and I still have not sent the required WineTest.exe patch.
But it's next in line now.


-- 
Francois Gouget <fgouget at codeweavers.com>


More information about the wine-devel mailing list