[PATCH 1/2] msado15: Set refs value for Field.

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Wed Mar 17 05:47:08 CDT 2021


Just ignore this for now.  Need to think a little more on how this ref 
value actually works.

The second patch shows that you can get a Field multiple times without 
issues.  The current implementation of the reference counting causes 
crashes with that patch.

Alistair.

On 17/3/21 9:16 pm, Alistair Leslie-Hughes wrote:
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
> ---
>   dlls/msado15/recordset.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/dlls/msado15/recordset.c b/dlls/msado15/recordset.c
> index 0b91358f83d..6b97e84e41f 100644
> --- a/dlls/msado15/recordset.c
> +++ b/dlls/msado15/recordset.c
> @@ -461,6 +461,7 @@ static HRESULT Field_create( const WCHAR *name, LONG index, struct recordset *re
>       }
>       field->index = index;
>       field->recordset = recordset;
> +    field->refs = 1;
>   
>       *obj = &field->Field_iface;
>       TRACE( "returning iface %p\n", *obj );
> 



More information about the wine-devel mailing list