[PATCH] winetest: Guess when to append the .dll extension.

[Francois Gouget]

On Sun, 21 Mar 2021, Zebediah Figura (she/her) wrote:

> On 3/21/21 1:11 PM, Francois Gouget wrote:
> > WineTest derives the dll name from the test executable filename. However
> > the '.dll' extension is omitted in the executable filename. So if the
> > guessed library name does not already have a three-letter extension
> > (such as .ocx, .sys, etc.), assume it should have the '.dll' extension.
> > 
> > Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> > ---
> > This allows WineTest to retrieve the version information for
> > windows.media.speech.dll.
> > This is pretty ugly but at least it's a simple patch. Plus three
> > letters should be enough for any library extension ;-)
> > ---
> >   programs/winetest/main.c | 10 +++++++++-
> >   1 file changed, 9 insertions(+), 1 deletion(-)
> > 
> 
> I don't know if any WinRT DLLs end in a three-letter word, but it seems not
> implausible...
> 
> Wouldn't it be more consistent and easier just to name the directory
> "windows.media.speech.dll", and the test "windows.media.speech.dll_test.exe",
> and then the rule everywhere becomes "if there's no dot in the name already,
> append .dll or .exe"?

That's how Rémi's patches started but then they switched to not 
including the trailing .dll.

Compare: https://www.winehq.org/pipermail/wine-devel/2021-March/182127.html
To:      https://www.winehq.org/pipermail/wine-devel/2021-March/182686.html

Apparently there was also a setupapi issue (which he fixed) but 
presumably there was a decision at some point to keep omitting the .dll 
extension (I don't see it in the mailing list archives though).

-- 
Francois Gouget <fgouget at codeweavers.com>