[PATCH] sapi/tests: Update SpResourceManager test expectations for newer Windows.

Alexandre Julliard julliard at winehq.org
Tue Mar 23 16:25:51 CDT 2021


Gijs Vermeulen <gijsvrm at gmail.com> writes:

> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50841
> Signed-off-by: Gijs Vermeulen <gijsvrm at gmail.com>
> ---
>  dlls/sapi/tests/resource.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/dlls/sapi/tests/resource.c b/dlls/sapi/tests/resource.c
> index cbddaf6323a..e7776c9124a 100644
> --- a/dlls/sapi/tests/resource.c
> +++ b/dlls/sapi/tests/resource.c
> @@ -25,13 +25,14 @@
>  
>  #include "wine/test.h"
>  
> -#define EXPECT_REF(obj,ref) _expect_ref((IUnknown*)obj, ref, __LINE__)
> -static void _expect_ref(IUnknown *obj, ULONG ref, int line)
> +#define EXPECT_REF_BROKEN(obj,ref,brokenref) _expect_ref_broken((IUnknown*)obj, ref, brokenref, __LINE__)
> +static void _expect_ref_broken(IUnknown *obj, ULONG ref, ULONG brokenref, int line)

In general refcount tests are not very interesting, particularly if they
differ between Windows versions. I'd suggest to simply remove them.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list