[PATCH 1/3] msxml3/tests: Add a test for saving XML with not default encoding.

Nikolay Sivov nsivov at codeweavers.com
Wed Mar 24 03:36:52 CDT 2021


On 3/24/21 10:42 AM, Dmitry Timoshkov wrote:
> What's the status of the first two patches in the series?
>
Encoding you used seems to be a reason for broken Vista case. Since this
does not test anything encoding-specific, utf-8 will make it work
without broken() cases. Test itself belongs to test_save().

Regarding 2/3, the reason to unlink originally was to fix duplicated
prologs, occasionally appearing in output. I don't remember details now,
it's possible it was about first loading document, and then inserting
prolog PI. This is again a case where implementing own dumping logic
will help, both with prolog and newlines.



More information about the wine-devel mailing list