[PATCH] msado15: Implement _Recordset get/put Bookmark

Hans Leidekker hans at codeweavers.com
Thu Mar 25 04:35:15 CDT 2021


On Thu, 2021-03-25 at 20:24 +1100, Alistair Leslie-Hughes wrote:
>  static HRESULT WINAPI recordset_put_Bookmark( _Recordset *iface, VARIANT bookmark )
>  {
> -    FIXME( "%p, %s\n", iface, debugstr_variant(&bookmark) );
> -    return E_NOTIMPL;
> +    struct recordset *recordset = impl_from_Recordset( iface );
> +    TRACE( "%p, %s\n", iface, debugstr_variant(&bookmark) );
> +    if (V_VT(&bookmark) != VT_I4)
> +        ERR("Unexpected type %d\n", V_VT(&bookmark));
> +
> +    recordset->index = V_I4(&bookmark);
> +    return S_OK;
>  }

Please add a test to show what should be done with invalid input.





More information about the wine-devel mailing list