[PATCH] conhost: Fix wrapping when write_console finishes on line end.
Jacek Caban
jacek at codeweavers.com
Wed Mar 31 07:27:28 CDT 2021
On 3/31/21 1:42 PM, Gabriel Ivăncescu wrote:
> This makes it pass on Windows, since it always outputs a newline
> immediately and never a backspace. In fact, removing the condition at
> all will *still* pass on Windows. So this condition is there for Wine?
> Is there a reason for it? And what should I keep in mind here to solve
> this "properly"?
>
> If you remove the condition, of course wine will fail the tests, but
> Windows won't. I really don't understand it.
Windows behavior isn't consistent between versions here. When I wrote
those tests it was a relatively fresh feature and its output changed
between Windows updates. Tests were written in a way that would accept
all of them. Hopefully things have matured now and it's good that
behavior of recent versions is better. We should follow that and
probably even mark those '\b' code paths as broken.
Jacek
More information about the wine-devel
mailing list