[PATCH 5/5] msi: Check for a NULL return from deformat_string() when checking for failure.
Zebediah Figura
z.figura12 at gmail.com
Sun May 2 21:42:47 CDT 2021
An empty string is valid, and can occur if e.g. a nonexistent property is
expanded.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51091
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
dlls/msi/action.c | 69 +++++++++++++++++++++++++++--------------
dlls/msi/tests/action.c | 8 ++++-
2 files changed, 52 insertions(+), 25 deletions(-)
diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index bcb1a4f578e..68688713074 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -6790,25 +6790,34 @@ static UINT ITERATE_WriteEnvironmentString( MSIRECORD *rec, LPVOID param )
if (res != ERROR_SUCCESS || !value)
goto done;
- if (value && !deformat_string(package, value, &deformatted))
+ if (value)
{
- res = ERROR_OUTOFMEMORY;
- goto done;
- }
+ DWORD len = deformat_string( package, value, &deformatted );
+ if (!deformatted)
+ {
+ res = ERROR_OUTOFMEMORY;
+ goto done;
+ }
- if ((value = deformatted))
- {
- if (flags & ENV_MOD_PREFIX)
+ if (len)
{
- p = wcsrchr( value, ';' );
- len_value = p - value;
+ value = deformatted;
+ if (flags & ENV_MOD_PREFIX)
+ {
+ p = wcsrchr( value, ';' );
+ len_value = p - value;
+ }
+ else if (flags & ENV_MOD_APPEND)
+ {
+ value = wcschr( value, ';' ) + 1;
+ len_value = lstrlenW( value );
+ }
+ else len_value = lstrlenW( value );
}
- else if (flags & ENV_MOD_APPEND)
+ else
{
- value = wcschr( value, ';' ) + 1;
- len_value = lstrlenW( value );
+ value = NULL;
}
- else len_value = lstrlenW( value );
}
res = open_env_key( flags, &env );
@@ -6997,22 +7006,34 @@ static UINT ITERATE_RemoveEnvironmentString( MSIRECORD *rec, LPVOID param )
return ERROR_SUCCESS;
}
- if (value && !deformat_string( package, value, &deformatted ))
- return ERROR_OUTOFMEMORY;
-
- if ((value = deformatted))
+ if (value)
{
- if (flags & ENV_MOD_PREFIX)
+ DWORD len = deformat_string( package, value, &deformatted );
+ if (!deformatted)
{
- p = wcschr( value, ';' );
- len_value = p - value;
+ res = ERROR_OUTOFMEMORY;
+ goto done;
}
- else if (flags & ENV_MOD_APPEND)
+
+ if (len)
{
- value = wcschr( value, ';' ) + 1;
- len_value = lstrlenW( value );
+ value = deformatted;
+ if (flags & ENV_MOD_PREFIX)
+ {
+ p = wcsrchr( value, ';' );
+ len_value = p - value;
+ }
+ else if (flags & ENV_MOD_APPEND)
+ {
+ value = wcschr( value, ';' ) + 1;
+ len_value = lstrlenW( value );
+ }
+ else len_value = lstrlenW( value );
+ }
+ else
+ {
+ value = NULL;
}
- else len_value = lstrlenW( value );
}
r = open_env_key( flags, &env );
diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c
index a5d2882acda..17de636ae52 100644
--- a/dlls/msi/tests/action.c
+++ b/dlls/msi/tests/action.c
@@ -249,7 +249,9 @@ static const char env_environment_dat[] =
"Var27\t+-MSITESTVAR21\t[~];1\tOne\n"
"Var28\t-MSITESTVAR22\t1\tOne\n"
"Var29\t-MSITESTVAR23\t2\tOne\n"
- "Var30\t*MSITESTVAR100\t1\tOne\n";
+ "Var30\t*MSITESTVAR100\t1\tOne\n"
+ "Var31\t-=MSITESTVAR24\t[SERVNAME]\tOne\n"
+ "Var32\t-=MSITESTVAR25\t[bogus_prop]\tOne\n";
static const char service_install_dat[] =
"ServiceInstall\tName\tDisplayName\tServiceType\tStartType\tErrorControl\t"
@@ -5044,6 +5046,7 @@ static void test_envvar(void)
CHECK_REG_STR(env, "MSITESTVAR19", "1");
CHECK_REG_STR(env, "MSITESTVAR20", "1");
CHECK_REG_STR(env, "MSITESTVAR21", "1");
+ CHECK_REG_STR(env, "MSITESTVAR24", "TestService");
CHECK_REG_STR(env2, "MSITESTVAR100", "1");
res = RegSetValueExA(env, "MSITESTVAR22", 0, REG_SZ, (const BYTE *)"1", 2);
@@ -5052,6 +5055,9 @@ static void test_envvar(void)
res = RegSetValueExA(env, "MSITESTVAR23", 0, REG_SZ, (const BYTE *)"1", 2);
ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res);
+ res = RegDeleteValueA(env, "MSITESTVAR25");
+ ok(res == ERROR_FILE_NOT_FOUND, "Expected ERROR_FILE_NOT_FOUND, got %d\n", res);
+
r = MsiInstallProductA(msifile, "REMOVE=ALL");
ok(!r, "got %u\n", r);
--
2.30.2
More information about the wine-devel
mailing list