[PATCH v2] winex11.drv: Handle Vulkan surface creation with NULL hwnd.

[Rémi Bernon]

On 5/3/21 11:56 AM, Paul Gofman wrote:
> On 5/3/21 12:52, Rémi Bernon wrote:
>>
>> No idea, I think winex11 is a bit messy but except for some parts I
>> think it tends to follow Julliard style (as ntdll for instance), with
>> line continuations aligned with the corresponding element on the
>> previous line.
>>
> If there is actually no consistent rule for indentation I'd suggest that
> maybe its ok to just follow wined3d style (two indentation positions for
> continued lines), given it also used often now throughout all the Wine
> code. Which has an advantage that you don't have to think of that and
> always have it consistent. But for now I will just change the way you
> suggest.
> 

Is it really? I'm sure it depends on the maintainer. Also winex11 code 
is not completely consistent but still, most of its code is not 
following this rule, and new code that has been recently added to it 
don't either.

Although I agree the said rule is convenient to think less about the 
indentation, in this specific case (the ternary operator) I really find 
it less readable.

IMHO if we really want to stop thinking about indentation we should use 
automatic indentation tools, not rules that makes things less readable.

Maybe the best fix is then not to use a ternary operator.
-- 
Rémi Bernon <rbernon at codeweavers.com>