[PATCH v2] winex11.drv: Handle Vulkan surface creation with NULL hwnd.
Rémi Bernon
rbernon at codeweavers.com
Mon May 3 05:16:37 CDT 2021
On 5/3/21 12:08 PM, Paul Gofman wrote:
> On 5/3/21 13:03, Rémi Bernon wrote:
>>
>> Is it really? I'm sure it depends on the maintainer. Also winex11 code
>> is not completely consistent but still, most of its code is not
>> following this rule, and new code that has been recently added to it
>> don't either.
>>
>> Although I agree the said rule is convenient to think less about the
>> indentation, in this specific case (the ternary operator) I really
>> find it less readable.
>>
>> IMHO if we really want to stop thinking about indentation we should
>> use automatic indentation tools, not rules that makes things less
>> readable.
>
> I am not sure how automatic indentation tool can manage if we can't
> formulate the rule for indentation?
>
I believe aligning operators (or line continuations) with the previous
line is a pretty common style, generally considered as readable [*]. And
although it's not written anywhere I think it's how most winex11.drv
code is written.
[*] Of course it's still a matter of personal taste but there's enough
examples of code using such style out there to assume it's the case.
--
Rémi Bernon <rbernon at codeweavers.com>
More information about the wine-devel
mailing list