[tools] winetest/build-patterns: Fix detecting transitions in non-run-time failures.

Francois Gouget fgouget at codeweavers.com
Mon May 3 07:45:11 CDT 2021


Record the first failure type so changes can be detected later on.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 winetest/build-patterns | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/winetest/build-patterns b/winetest/build-patterns
index 460c17c1b..a84e2a7ea 100755
--- a/winetest/build-patterns
+++ b/winetest/build-patterns
@@ -480,12 +480,15 @@ foreach my $testname (keys %tests)
             }
             next if ($status eq "skipped"); # same as if WineTest was not run
 
-            # It is not an error if the dll is missing (or other similar
-            # error) _and_ it has always been so.
             my $failtype = fail_type($status);
-            next if ($testreport->{failtype} eq "" and $failtype ne "random");
-
-            if ($testreport->{failtype} ne $failtype)
+            if ($testreport->{failtype} eq "" and $failtype ne "random")
+            {
+                # It is not an error if the dll is missing (or other similar
+                # error) _and_ it has always been so. So just record failtype
+                # for now.
+                $testreport->{failtype} = $failtype;
+            }
+            elsif ($testreport->{failtype} ne $failtype)
             {
                 # Either there was no failure before; or the failure type
                 # changed in a way that cannot be explained by randomness; e.g.
-- 
2.20.1




More information about the wine-devel mailing list