[PATCH 4/4] ucrtbase: Add tests for _beginthread[ex]().

Piotr Caban piotr.caban at gmail.com
Mon May 3 11:59:01 CDT 2021


On 5/3/21 6:37 PM, Arkadiusz Hiler wrote:
> On Mon, May 03, 2021 at 06:06:35PM +0200, Piotr Caban wrote:
>> On 5/3/21 3:07 PM, Arkadiusz Hiler wrote:
>>> +static unsigned internal_thread_proc(void *param)
>>> +{
>>> +    struct threaddll_args *args = param;
>>> +    SetEvent(args->confirm_running);
>>> +    WaitForSingleObject(args->past_free, 100);
>> It doesn't matter that much in this case but please test WaitForSingleObject
>> return value. It can still give some hints if tests start to fail.
> 
> Any standard way to do that from DLLs? The current winetest_*()
> implementation is not really meant for this use case, as it defines all
> the function in testlist.c (#define STANDALONE) + adds a main() and
> requires winetest_testlist.
I don't know, probably it's not worth to invent something here. How 
about changing the timeout to INFINITE then?



More information about the wine-devel mailing list