[PATCH 1/4] user32: Factor GetKeyboardLayoutNameW implementations.

Rémi Bernon rbernon at codeweavers.com
Tue May 4 05:27:14 CDT 2021


On 5/4/21 11:37 AM, Alexandre Julliard wrote:
> Rémi Bernon <rbernon at codeweavers.com> writes:
> 
>> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
>> ---
>>   dlls/user32/driver.c              | 13 -------------
>>   dlls/user32/input.c               | 20 ++++++++++++++++----
>>   dlls/user32/user_private.h        |  1 -
>>   dlls/winemac.drv/keyboard.c       | 15 ---------------
>>   dlls/winemac.drv/winemac.drv.spec |  1 -
>>   dlls/winex11.drv/keyboard.c       | 16 +---------------
>>   dlls/winex11.drv/winex11.drv.spec |  1 -
>>   7 files changed, 17 insertions(+), 50 deletions(-)
> 
> This causes breakage in the initial prefix creation:
> 
> wine: created the configuration directory '/home/julliard/.wine'
> 002c:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
> 002c:err:winediag:nodrv_CreateWindow The explorer process failed to start.
> 

Indeed, looks like that calling GetKeyboardLayoutNameW from winex11.drv 
keyboard initialization causes some initialization loop (itself calling 
GetKeyboardLayout(0) which goes to winex11.drv again), which ultimately 
fails...

Sorry I missed that, I'll find a fix.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list