[PATCH 1/5] user32: Update keyboard / mouse rawinput device paths.

[Rémi Bernon]

On 5/12/21 11:49 AM, Marvin wrote:
> Hi,
> 
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> 
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=90253
> 
> Your paranoid android.
> 
> 
> === debiant2 (32 bit Chinese:China report) ===
> 
> user32:
> input.c:2160: Test failed: GetRawInputBuffer returned 4
> input.c:2155: Test failed: GetRawInputBuffer returned unexpected size: 0
> input.c:2160: Test failed: GetRawInputBuffer returned 0
> input.c:2161: Test failed: GetRawInputBuffer returned unexpected size: 0
> input.c:2162: Test failed: Unexpected rawinput data: 0
> input.c:2163: Test failed: Unexpected rawinput data: 0
> input.c:2164: Test failed: Unexpected rawinput data: 0
> input.c:2222: Test failed: GetRawInputData succeeded
> input.c:2223: Test failed: GetRawInputData returned deadbeef
> input.c:2336: Test failed: Spurious WM_INPUT messages
> 
> === debiant2 (64 bit WoW report) ===
> 
> user32:
> input.c:2160: Test failed: GetRawInputBuffer returned 4
> input.c:2222: Test failed: GetRawInputData succeeded
> input.c:2223: Test failed: GetRawInputData returned deadbeef
> input.c:2336: Test failed: Spurious WM_INPUT messages
> 

I think these as well as the failures on patch 3 and 4 (which are the 
same), are spurious failures. I'm not completely sure about the 
conditions to make it happen, but I suspect that it can if mouse motion 
events take some unusual time to be received.

The test is supposed to do several mouse movements, which should also 
update the X11 mouse position using SetCursorPos, triggering some real 
motion events, and it then expect to receive several WM_INPUT messages 
at the same time. One is getting processed from the message loop, and 
the other are expected to be found when calling GetRawInputBuffer.

I've run the tests manually again here, and they don't fail this time:

https://testbot.winehq.org/JobDetails.pl?Key=90266
https://testbot.winehq.org/JobDetails.pl?Key=90267

-- 
Rémi Bernon <rbernon at codeweavers.com>