[PATCH 3/4] user32/tests: Use empty_message_queue to peek messages.

Rémi Bernon rbernon at codeweavers.com
Fri May 14 08:19:39 CDT 2021


On 5/14/21 12:18 PM, Rémi Bernon wrote:
> On 5/14/21 12:14 PM, Marvin wrote:
>> Hi,
>>
>> While running your changed tests, I think I found new failures.
>> Being a bot and all I'm not very good at pattern recognition, so I 
>> might be
>> wrong, but could you please double-check?
>>
>> Full results can be found at:
>> https://testbot.winehq.org/JobDetails.pl?Key=90474
>>
>> Your paranoid android.
>>
>>
>> === w7u_2qxl (32 bit report) ===
>>
>> user32:
>> input.c:757: Test failed:  0 (a4/0): 00 from 00 -> 80 unexpected
>> input.c:757: Test failed:  0 (a4/0): 41 from 01 -> 00 unexpected
>>
>> === w7u_el (32 bit report) ===
>>
>> user32:
>> input.c:4445: Test failed: SendInput triggered unexpected message 0xc042
>>
>> === w1064v1809 (32 bit report) ===
>>
>> user32:
>> input.c:2787: Test failed: 0: expected WM_MOUSEMOVE message
>> input.c:2787: Test failed: 1: expected WM_MOUSEMOVE message
>> input.c:2787: Test failed: 2: expected WM_MOUSEMOVE message
>>
>> === wvistau64 (64 bit report) ===
>>
>> user32:
>> input.c:757: Test failed:  0 (a4/0): 01 from 01 -> 00 unexpected
>> input.c:757: Test failed:  0 (a4/0): 11 from 01 -> 00 unexpected
>> input.c:757: Test failed:  0 (a4/0): a2 from 01 -> 00 unexpected
>>
>> === w1064_tsign (64 bit report) ===
>>
>> user32:
>> input.c:3517: Test failed: expected loop with WM_NCHITTEST messages
>> input.c:3570: Test failed: expected WM_LBUTTONDOWN message
>> input.c:3571: Test failed: expected WM_LBUTTONUP message
>>
>> === w10pro64_ja (64 bit report) ===
>>
>> user32:
>> input.c:1303: Test failed: Wrong set pos: (99,100)
>> input.c:1323: Test failed: GetCursorPos: (99,100)
>>
> 
> Seems to be passing now but I still wouldn't call it a victory. I think 
> the failures are more likely to appear when all user32 tests are run at 
> once (maybe caused by some left over state from previous tests).

I'm actually able to reproduce the failures locally when running the 
tests through winetest. These patches won't fix the problem, although 
picking them probably won't hurt either.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list