[PATCH v3 1/3] winevulkan: Add support for unwrapping handles in thunks.

[Georg Lehmann]

On 14.05.21 17:59, Derek Lesho wrote:
> On 5/14/21 11:50 AM, Zebediah Figura (she/her) wrote:
> 
>> This is an awful lot of churn for the amount of manual code it saves. 
>> Is this really worthwhile?
>>
> On its own, I would agree with you, but once we turn VkDeviceMemory into 
> a wrapped handle type, it saves a more considerable amount of manual 
> code.  We'd have to add manual conversion for these dynamic arrays with 
> wrapped handles:
> 
> VkBindAccelerationStructureMemoryInfoNV
> 
> VkBindBufferMemoryInfo
> 
> VkBindImageMemoryInfo
> 
> VkMappedMemoryRange
> 
> VkSparseMemoryBind
> 
> VkSparseImageMemoryBind
> 
> 
> And this struct:
> 
> VkDeviceMemoryOpaqueCaptureAddressInfo
> 
> 

It should also be noted that this reduces the risk of overlooking 
functions which need manual handle unwrapping on spec updates, as has 
happened with vkQueueSubmit2KHR.