[PATCH 2/3] include: Introduce winetest_push_context() and winetest_pop_context().

[Zebediah Figura (she/her)]

On 5/15/21 9:48 AM, Francois Gouget wrote:
> On Sun, 25 Apr 2021, Zebediah Figura wrote:
> [...]
>> @@ -298,8 +303,11 @@ const char *winetest_elapsed(void)
>>   static void winetest_vprintf( const char *msg, __winetest_va_list args )
>>   {
>>       struct tls_data *data = get_tls_data();
>> +    unsigned int i;
>>   
>>       printf( "%s:%d:%s ", data->current_file, data->current_line, winetest_elapsed() );
>> +    for (i = 0; i < data->context_count; ++i)
>> +        printf( "%s: ", data->context[i] );
>>       vprintf( msg, args );
>>   }
> 
> This prevents the TestBot and test.winehq.org from recognizing test
> failures when there's a context string. The Testbot expects
> 
>     [_a-z0-9]+\.c:\d+:[0-9.]* Test failed:
> 
> But it gets lines like this instead:
> 
> registry.c:4104: L"Bahia Standard Time": Test failed: expected L"Bahia Daylight Time", got L"Bahia (heure d'\00e9t\00e9)"
> 
> Ideally the context would go after "Test failed:". Otherwise that means
> allowing anything in between the file+line and "Test failed:" which
> increases the risk of allowing bad matches.
> 
> Note: Same goes for "Test succeeded inside todo block", "Test
>        marked todo", etc.
> 

Sorry, I didn't consider that. I've sent a patch.