[PATCH v2 3/6] strmbase: Defer EC_COMPLETE until the renderer is running.

Zebediah Figura (she/her) zfigura at codeweavers.com
Mon May 24 23:56:18 CDT 2021


This causes test failures for me:

> leslie at terabithia:~/git/wine64/dlls/quartz/tests$ make && ~/git/wine/tools/runtest filtergraph
> make[1]: Entering directory '/home/leslie/git/wine64'
> make[1]: Nothing to be done for 'dlls/quartz/tests/all'.
> make[1]: Leaving directory '/home/leslie/git/wine64'
> 002c:err:wineboot:process_run_key Error running cmd L"C:\\windows\\system32\\winemenubuilder.exe -a -r" (2).
> 00bc:fixme:quartz:FilterGraphInner_QueryInterface unknown interface {56a86895-0ad4-11ce-b03a-0020af0ba770}
> filtergraph.c:606: running L"test.avi"
> 00bc:err:winediag:MIDIMAP_drvOpen No software synthesizer midi port found, Midi sound output probably won't work.
> 00bc:fixme:ntdll:NtQuerySystemInformation info_class SYSTEM_PERFORMANCE_INFORMATION
> 00bc:err:quartz:MediaFilter_GetState Filter 0000000001402860 reported incorrect state 2 (expected 1).
> 00bc:err:quartz:MediaFilter_GetState Filter 0000000001401F40 reported incorrect state 2 (expected 1).
> 00bc:err:quartz:MediaFilter_GetState Filter 00000000014017C0 reported incorrect state 2 (expected 1).
> 00bc:err:quartz:MediaFilter_GetState Filter 00000000014017C0 reported incorrect state 2 (expected 1).
> 00bc:err:quartz:MediaFilter_GetState Filter 0000000001402920 reported incorrect state 2 (expected 1).
> 00bc:err:quartz:MediaFilter_GetState Filter 0000000001401F40 reported incorrect state 2 (expected 1).
> filtergraph.c:606: running L"test.mpg"
> 00bc:err:quartz:MediaFilter_GetState Filter 0000000001403A70 reported incorrect state 2 (expected 1).
> 00bc:err:quartz:MediaFilter_GetState Filter 00000000014031E0 reported incorrect state 2 (expected 1).
> 00bc:err:quartz:MediaFilter_GetState Filter 0000000001402920 reported incorrect state 2 (expected 1).
> 00bc:err:quartz:MediaFilter_GetState Filter 0000000001401F40 reported incorrect state 2 (expected 1).
> filtergraph.c:515: Test failed: didn't get EOS
> filtergraph.c:519: Test failed: expected 1243c8, got 0

You probably want to move the diff to renderer_start_stream() above the 
line resetting "filter->eos" to zero, or reorder this patch with 4/6.



More information about the wine-devel mailing list