[PATCH 4/4] dinput: Implement DIPROP_APPDATA.

[Rémi Bernon]

On 5/25/21 9:21 PM, Francois Gouget wrote:
> Hi,
> 
> On Mon, 8 Mar 2021, Arkadiusz Hiler wrote:
> 
>> This fixes not working analog inputs on game controllers in Slay the Spire.
>>
>> Signed-off-by: Arkadiusz Hiler <ahiler at codeweavers.com>
> 
> This commit is causing a new failure on w10pro64-fr, and only on that
> machine:
> https://bugs.winehq.org//show_bug.cgi?id=50987
> 
> Do you have any insight or even a fix for it?
> 
> 

As it's on fr windows and the test registers DIK_A / sends 'A' key 
event, I'd say it's most likely related to the layout.

I noticed there's some other dinput test which fails, on Wine, because 
of French layout too [1].

I think it's going to be hard to write tests robust enough to pass with 
all the possible layouts, and if the tests aren't meant to validate some 
localization aspect, they could perhaps be skipped on non-US locales.

[1] 
https://test.winehq.org/data/dff85646517526562644c23648d11596daeb26d0/linux_fg-deb64-t32/dinput:keyboard.html
-- 
Rémi Bernon <rbernon at codeweavers.com>