[PATCH 6/7] wineboot: Initialize XState features in user_shared_data.

[Francois Gouget]

On Wed, 26 May 2021, Paul Gofman wrote:

> On 5/26/21 15:17, Francois Gouget wrote:
> > On Wed, 26 May 2021, Paul Gofman wrote:
> >
> >> FWIW the tests succeed on real hardware for me (64 bit, xstate
> >> supported) on Win7 and Win10 (latest; the broken case is not hit). I
> >> suspect the fall into broken case has something to do with VM specifics,
> > Not so for Windows 10 since it falls into the broken case on cw-rx460 
> > (Windows 10 1507) which is not a VM (i7-2600K + AMD RX460 graphics 
> > card):
> >
> So if it is different for different real hw Win10 machines, but the
> reason is not known, can't that result just stay broken

It seems wrong to me to claim a Windows behavior is broken if:
1. It is the behavior of all recent Windows versions.
2. We have no idea why some machines behave differently.
3. We have no idea how many machines exhibit the 'broken' behavior.
   (If 90% of the Windows machines 'in the wild' exhibit the broken 
   behavior then this is the behavior that will be expected)

Options:
1. Drop the test
   If we don't know of Windows applications that depend on this 
   aspect and don't expect them to, then maybe the test is not needed.
2. Investigate more to actually understand what is going on.
   Then we can decide what to do.
3. Leave it as is
   The broken is not causing failures so it's ok. Change the 
   comment to a FIXME explaining we don't know what's going on.
   That also means we don't know how to implement this in Wine.


> (whatever the reason for that is, would it be 1507 version, CPU model 
> or some setup quirk)?

I am not going to test all the Windows versions on cw-gtx560 and 
cw-rx460 because each time it requires manually reimaging the partition, 
manually stopping WineTest before it starts, manually transferring the 
test executable and manually running it.

But it's not just Windows 10 1507, the test fails in the same way on:

cw-gtx560  Win10 1909 i7-2600K               broken (success)
cw-rx460   Win10 2009 i7-2600K               broken (success)

That's consistent with the VMs behavior so there is no reason to expect 
other Windows versions would behave differently.


> I have all the default system with all the updates auto installed 
> here, so unlikely something in my setup makes it work in an unusual 
> way.

I can say the same for cw-rx460 and cw-gtx560: there may be some setting 
that makes a difference but at least they are all tracked on the page 
below so there's not a lot.

https://wiki.winehq.org/Wine_TestBot_VMs#Windows_configuration


-- 
Francois Gouget <fgouget at codeweavers.com>