[PATCH v2 3/4] mf: Generate missing MEStreamSinkPaused event in the sample grabber.

Nikolay Sivov nsivov at codeweavers.com
Fri May 28 04:50:21 CDT 2021



On 5/28/21 12:13 PM, Giovanni Mascellani wrote:
> Il 28/05/21 10:29, Nikolay Sivov ha scritto:
>> This is incomplete, for several reasons. Pause when stopped is an
>> invalid transition; pause when already paused should not generate an
>> event.
>
> Ok. Should I write additional tests for these cases? Last time you
> suggested that I was writing too many tests, so I would like to
> understand what is the right amount.
>

That's easily observable with tests from 2/4 and a couple more calls. We
do need more tests in general, but not potentially fragile ones, and
event collection appears to be that for media foundation.

> Thanks again, Giovanni.
>




More information about the wine-devel mailing list