[PATCH v5 3/7] win32u: fix return value of StretchDIBits for EMF DC.

[Jacek Caban]

Hi Jinoh,

On 11/1/21 6:30 AM, Jinoh Kang wrote:
> Signed-off-by: Jinoh Kang <jinoh.kang.kr at gmail.com>
> ---
>   dlls/win32u/emfdrv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/win32u/emfdrv.c b/dlls/win32u/emfdrv.c
> index e05f11d7b9a..395d51048d8 100644
> --- a/dlls/win32u/emfdrv.c
> +++ b/dlls/win32u/emfdrv.c
> @@ -408,7 +408,7 @@ static INT CDECL EMFDRV_StretchDIBits( PHYSDEV dev, INT x_dst, INT y_dst, INT wi
>                                          UINT wUsage, DWORD dwRop )
>   {
>       /* FIXME: Update bound rect */
> -    return height_src;
> +    return abs( info->bmiHeader.biHeight );
>   }
>   
>   static INT CDECL EMFDRV_SetDIBitsToDevice( PHYSDEV dev, INT x_dst, INT y_dst, DWORD width,


For this and the next patch, you could simply remove 
EMFDRV_StretchDIBits and EMFDRV_SetDIBitsToDevice and let the null 
driver take care of it. I originally left it because of bound rect 
update (that's supposed to happen in win32u instead of of gdi32), but 
that doesn't seem worth keeping it now.


Thanks,

Jacek