[PATCH v4 1/3] uiautomationcore: Implement UiaGetReservedNotSupportedValue.

Connor McAdams cmcadams at codeweavers.com
Thu Nov 4 09:02:08 CDT 2021


On Tue, Nov 02, 2021 at 02:40:03AM +0300, Nikolay Sivov wrote:
> 
> 
> On 10/29/21 4:43 PM, Connor McAdams wrote:
> > +struct uia_rsrv_obj_marshal_wrapper
> > +{
> > +    IUnknown IUnknown_iface;
> > +    LONG refcount;
> > +
> > +    IUnknown *marshaler;
> > +    IUnknown *marshal_object;
> > +};
> > +
> > +static struct uia_rsrv_obj_marshal_wrapper *impl_uia_rsrv_obj_marshal_wrapper_from_IUnknown(IUnknown *iface)
> > +{
> > +    return CONTAINING_RECORD(iface, struct uia_rsrv_obj_marshal_wrapper, IUnknown_iface);
> > +}
> > +static HRESULT uia_rsrv_obj_create_marshal_wrapper(IUnknown *reserved, void **ppv)
> > +{
> 
> Other than naming, I think this looks good now. I'm not sure if this is
> waiting for someone to sign off.
>

Yeah, I think it needs a sign-off from somebody other than myself. If
you'd be willing to, that'd probably help. If you'd like me to change
the naming to get your sign-off, just let me know what to rename and
I'll send in a new series. :)

Thanks.



More information about the wine-devel mailing list