[PATCH v6 1/2] ntdll: Allow loading system DLLs from a path specified at configure time.

[Zebediah Figura (she/her)]

On 11/11/21 11:17, Alexandre Julliard wrote:
> "Zebediah Figura (she/her)" <zfigura at codeweavers.com> writes:
> 
>> On 11/11/21 02:52, Alexandre Julliard wrote:
>>> Zebediah Figura <zfigura at codeweavers.com> writes:
>>>
>>>> Many distributions provide MinGW-compiled system DLLs which are currently
>>>> bundled with Wine. Unfortunately, while MinGW pkg-config can be used to detect
>>>> the linking path, there is no standardized runtime path, and many distributions
>>>> in fact use different paths.
>>> I think it needs to be a proper path containing multiple
>>> directories, at
>>> least to allow supporting both 32- and 64-bit dlls. Otherwise there
>>> would need to be some sort of mapping from PE architecture to system
>>> dir.
>>>
>>
>> The way it's done currently by this patch is already per-architecture.
>>
>> I suspect that you want to take into account shared WoW64 support from
>> a single tree. My guess is that we want two separate variables, so
>> that we don't end up unnecessarily searching the wrong path, but the
>> infrastructure isn't there yet for that. In lieu of that I'll use a
>> semicolon-separated list. That's probably desirable anyway (to allow
>> for e.g. /usr/local/lib/ + /usr/lib/).
> 
> Note that it's not just two variables, for instance we also want to
> support x86 on ARM.  The infrastructure for that is already there in the
> loader.
> 

Right. There's support for constructing a Wine-specific path based on 
architecture, but it's not clear to me yet that it would make sense to 
add multiple variables as long as we only have one architecture per 
build tree.

I'd wait until that part is done, but I'd really like to make sure this 
support gets into 7.0, if I can, for distributions' sake...