[PATCH v3 3/9] winedbg: Generalise packet_realloc(), rename to buffer_realloc().

Rémi Bernon rbernon at codeweavers.com
Tue Nov 16 10:58:14 CST 2021


On 11/16/21 17:51, Jinoh Kang wrote:
> Make it return void * and accept size_t as the size.
> 
> Signed-off-by: Jinoh Kang <jinoh.kang.kr at gmail.com>
> ---

Hi Jinoh,

I think that now winegdb has been converted to PE format, you can 
instead convert all Heap* allocations to standard C allocations, and use 
realloc directly instead of the helper.

Regarding the errors, maybe add some assert calls if you like, although 
I don't think we usually use that or HEAP_GENERATE_EXCEPTIONS flag, and 
instead we just consider that if allocation returned NULL it should 
either be handled properly, or ignored and later access will cause 
exceptions.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list