[PATCH v3 6/9] winedbg: Buffer and escape output of GDB qXfer commands.

[Jinoh Kang]

Since vl_buffer is intended for non-ASCII data (including null byte), how about "packet_buffer" or "reply_buffer"?

On 11/17/21 02:24, Rémi Bernon wrote:
> On 11/16/21 18:22, Rémi Bernon wrote:
>> On 11/16/21 17:51, Jinoh Kang wrote:
>>> Signed-off-by: Jinoh Kang <jinoh.kang.kr at gmail.com>
>>> ---
>>>   programs/winedbg/gdbproxy.c | 284 +++++++++++++++++++++++++++---------
>>>   1 file changed, 211 insertions(+), 73 deletions(-)
>>>
>>> diff --git a/programs/winedbg/gdbproxy.c b/programs/winedbg/gdbproxy.c
>>> index bdb73659ade..caf64983c49 100644
>>> --- a/programs/winedbg/gdbproxy.c
>>> +++ b/programs/winedbg/gdbproxy.c
>>> @@ -54,6 +54,13 @@ struct gdb_xpoint
>>>       unsigned int value;
>>>   };
>>> +struct vl_buffer
>>> +{
>>> +    void *base;
>>> +    size_t len;
>>> +    size_t alloc;
>>> +};
>>> +
>>
>> I think vl_ prefix is not very useful, something like strbuf_ would be more readable IMHO.
> 
> Thinking about it "string_buffer" would be even better, I don't know why we keep trying to make things short.

-- 
Sincerely,
Jinoh Kang