[PATCH v5 01/11] jscript: Support deletion for accessor, builtin and idx props.

Gabriel Ivăncescu gabrielopcode at gmail.com
Fri Nov 19 12:03:41 CST 2021


Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
---
 dlls/jscript/dispex.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c
index e64a520..a5b3543 100644
--- a/dlls/jscript/dispex.c
+++ b/dlls/jscript/dispex.c
@@ -1630,10 +1630,14 @@ static HRESULT delete_prop(dispex_prop_t *prop, BOOL *ret)
 
     if(prop->type == PROP_JSVAL) {
         jsval_release(prop->u.val);
-        prop->type = PROP_DELETED;
     }
-    if(prop->type == PROP_ACCESSOR)
-        FIXME("not supported on accessor property\n");
+    if(prop->type == PROP_ACCESSOR) {
+        if(prop->u.accessor.getter)
+            jsdisp_release(prop->u.accessor.getter);
+        if(prop->u.accessor.setter)
+            jsdisp_release(prop->u.accessor.setter);
+    }
+    prop->type = PROP_DELETED;
     return S_OK;
 }
 
-- 
2.31.1




More information about the wine-devel mailing list