[PATCH v5 02/11] jscript: Use to_primitive when getting the default value for js objects.

Jacek Caban jacek at codeweavers.com
Mon Nov 22 06:22:45 CST 2021


Hi Gabriel,

On 11/19/21 7:03 PM, Gabriel Ivăncescu wrote:
> diff --git a/dlls/jscript/jscript.h b/dlls/jscript/jscript.h
> index 69897cd..d37fbd1 100644
> --- a/dlls/jscript/jscript.h
> +++ b/dlls/jscript/jscript.h
> @@ -230,6 +230,9 @@ typedef struct {
>       builtin_setter_t setter;
>   } builtin_prop_t;
>   
> +HRESULT jsdisp_builtin_get_default_value(script_ctx_t*,jsdisp_t*,jsval_t*) DECLSPEC_HIDDEN;
> +#define JSDISP_DEFINE_BUILTIN_VALUE(value) {NULL, value,0, jsdisp_builtin_get_default_value}


Could we just handle DISPID_VALUE in dispex.c callers without using 
builtin_prop_t at all?


Thanks,

Jacek




More information about the wine-devel mailing list