[PATCH 2/8] dbghelp: protect against missing compiland when adding global function...

Eric Pouech eric.pouech at gmail.com
Mon Nov 22 08:19:59 CST 2021


reported by:
- Coverity: CID 1493458, CID 1493456
- https://bugs.winehq.org/show_bug.cgi?id=52045

Signed-off-by: Eric Pouech <eric.pouech at gmail.com>

---
 dlls/dbghelp/symbol.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/dbghelp/symbol.c b/dlls/dbghelp/symbol.c
index 435d94bc8eb..2443dbf7e73 100644
--- a/dlls/dbghelp/symbol.c
+++ b/dlls/dbghelp/symbol.c
@@ -353,8 +353,11 @@ struct symt_function* symt_new_function(struct module* module,
         init_function_or_inlinesite(sym, module, SymTagFunction, &compiland->symt, name, addr, size, sig_type);
         sym->next_inlinesite = NULL; /* first of list */
         symt_add_module_ht(module, (struct symt_ht*)sym);
-        p = vector_add(&compiland->vchildren, &module->pool);
-        *p = &sym->symt;
+        if (compiland)
+        {
+            p = vector_add(&compiland->vchildren, &module->pool);
+            *p = &sym->symt;
+        }
     }
     return sym;
 }




More information about the wine-devel mailing list