[PATCH vkd3d 2/6] vkd3d-shader/hlsl: Do not delete the node in replace_node().

[Giovanni Mascellani]

Hi,

On 23/11/21 02:45, Zebediah Figura wrote:
> Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
> ---
> 
> This depends on 220151.

It also clashes with 220153, though it's easy to fix that.

I am not particularly opposed to this patch, but what is the reason? In 
most (if not all) cases, if you replace a node and don't remove it, it 
will eventually be removed by DCE, so the result is going to be the same 
in the end (maybe processing will be a little slower, but I don't think 
that's a big problem).

There are some cases in which it is necessary to immediately remove the 
replaced node, because otherwise optimization enters an infinite loop. 
Since you introduced replace_and_remove_node I guess you already 
discovered that the hard way! :-P

But are there cases in which it is necessary to _not_ remove the 
replaced node? Because if there aren't, I would just always remove it as 
it happens now, which seems to me the simplest solution.

Thanks, Giovanni.