[PATCH v6 03/12] jscript: Get rid of the value prop and use to_primitive when getting default value.

Jacek Caban jacek at codeweavers.com
Tue Nov 23 09:02:43 CST 2021


On 11/23/21 2:59 PM, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu<gabrielopcode at gmail.com>
> ---
>
> Since we get rid of the value prop itself, this requires adjustments to the
> DISPID to index parts, and the buckets (0 is now a valid index, so I used ~0).
>
> Note that the previous code was very confusing in some parts; it implicitly
> assumed that DISPID == index into the props (such as in get_flags), so it
> was fragile.


Please split it. You don't need to get rid of value prop in the same 
patch as you change dispex.c to use to_primitive(). This could be split 
into a few patches.


Jacek




More information about the wine-devel mailing list