[PATCH v7 0/7] winedbg(gdbproxy): don't misbehave on module names w/ special characters; modernise

Jinoh Kang jinoh.kang.kr at gmail.com
Tue Nov 23 09:08:40 CST 2021


Changelog:

v1 -> v2: address review comments so far
v2 -> v3:
- Change cover letter subject
- Capitalise subject
- Split qXfer cache patch into two
v3 -> v4:
- Fix pointer variable declaration style
- Synchronize to prior modified patches.
- Refactor the code a bit
- Revert to scanf() when parsing Xfer packet lines
- Fix indentation
- s/buffer_realloc/realloc/g
- s/vl_buffer/reply_buffer/g; s/vl_/reply_buffer_/g; s/vlbuf/reply/g
- Rewrite reply_buffer_add_uinthex(): convert for loop into while loop
- Rewrite reply_buffer_append_xmlstr(): convert for loop into while loop
- Split packet_reply_add() into packet_reply_add_data() here
- Rewrite packet_reply_add for clarity.
- Update Wine version in comment.
v4 -> v5:
- Fix pointer variable declaration style.
- Synchronize to prior modified patches.
- Split out XML escaping in a separate patch
- Don't realloc/free when emptying
- Drop reply_buffer_resize(), merge into reply_buffer_grow()
- Remove "more" variables for now
- Don't empty the reply buffer twice
- Use two sscanf for alternative patterns
- Don't always zero-initialise qxfer_object_annex
- Use strcpy (I just did what I was told to do)
- Use strcmp (I just did what I was told to do)
v5 -> v6:
- Remove a gratuitous blank line
- Edit commit messages
v6 -> v7:
- Change type of reply_buffer::base from void* to unsigned char*
- s/reply_buffer_empty/reply_buffer_clear/g
- Remove unused function reply_buffer_append_str
- Add function reply_buffer_append_str here
- packet_reply_xfer: Change type of `off` and `len` parameters to size_t
- packet_reply_xfer: Remove data and datalen parameters

Jinoh Kang (7):
  winedbg: Refactor gdb_context::out_{buf*,len} into reply_buffer.
  winedbg: Use exponential growth in gdbproxy reply_buffer_grow.
  winedbg: Buffer output of GDB qXfer commands for proper slicing.
  winedbg: Escape XML special characters in qXfer reply.
  winedbg: Define table for GDB qXfer command handlers.
  winedbg: Cache GDB qXfer command result for chunked fetching.
  winedbg: Implement GDB qXfer object exec-file.

 programs/winedbg/gdbproxy.c | 604 ++++++++++++++++++++++++------------
 1 file changed, 406 insertions(+), 198 deletions(-)

-- 
2.31.1




More information about the wine-devel mailing list