[PATCH v6 01/12] jscript: Treat prototype refs as non-existent when deleting.
Gabriel Ivăncescu
gabrielopcode at gmail.com
Tue Nov 23 09:45:17 CST 2021
On 23/11/2021 16:56, Jacek Caban wrote:
> On 11/23/21 2:59 PM, Gabriel Ivăncescu wrote:
>> diff --git a/dlls/mshtml/tests/documentmode.js
>> b/dlls/mshtml/tests/documentmode.js
>> index d5f33dd..041025c 100644
>> --- a/dlls/mshtml/tests/documentmode.js
>> +++ b/dlls/mshtml/tests/documentmode.js
>> @@ -1192,7 +1192,6 @@ sync_test("__proto__", function() {
>> ok(obj.__proto__ === ctor.prototype, "obj.__proto__ !==
>> ctor.prototype");
>> r = (delete x.__proto__);
>> - todo_wine.
>> ok(r, "delete x.__proto__ returned " + r);
>
>
> While the patch looks right, the test is very fragile. Please add a test
> using regular properties to jscript tests as well.
>
>
> Thanks,
>
> Jacek
>
Interesting. When writing the tests looks like I found out some more
bugs with PROTREFs, and since I'll split them up I'll probably resend
mostly the jscript series next time, to avoid sending too many patches
at once.
Thanks,
Gabriel
More information about the wine-devel
mailing list