[PATCH] user32: Send EVENT_OBJECT_FOCUS when the focus changes

Connor McAdams conmanx360 at gmail.com
Mon Nov 29 08:32:27 CST 2021


Yeah, I guess the question is whether or not that's acceptable
upstream, which I'm not really qualified to answer.

At the very least, if it's going to be partially implemented, the
title/commit message should probably mention this, i.e 'Partially
implement EVENT_OBJECT_FOCUS events.' or something along those lines.

On Sun, Nov 28, 2021 at 8:37 PM Alex Henrie <alexhenrie24 at gmail.com> wrote:
>
> On Sun, Nov 28, 2021 at 1:59 PM Connor McAdams <conmanx360 at gmail.com> wrote:
> >
> > Hi, are you sure this doesn't introduce new failures on wine, WRT
> > HCBT_SETFOCUS hooks? I sent a patch for this back in October, and it
> > had issues with those.
> > https://www.winehq.org/pipermail/wine-devel/2021-October/197568.html
>
> Thanks for the link, I wasn't aware of your previous patches for this
> issue. My patch is not as ambitious as yours: It only sends
> EVENT_OBJECT_FOCUS in one place, and only if another window previously
> had focus. I didn't do anything more comprehensive precisely because I
> wanted to be sure that the patch wouldn't break any tests.
>
> -Alex



More information about the wine-devel mailing list