[PATCH v4 8/9] user32: Invalidate cache in update_monitor_cache when modification time matches current time.

Jacek Caban jacek at codeweavers.com
Tue Nov 30 07:39:26 CST 2021


On 11/30/21 2:14 PM, rbernon at codeweavers.com wrote:
> On 11/30/21 1:26 PM, Jacek Caban <jacek at codeweavers.com> wrote:
>>
>> Also preserve last error.
>>
>
> FWIW I think I had similar problems with my nulldrv patches, and the 
> last error reset comes from CreateMutex. If you plan on using ntdll 
> functions directly (or if you don't, using them would), it should not 
> be necessary to save and restore last error.


The assumption that SetupAPI calls preserve last error seems 
questionable to me. Anyway, my plan is to move all update_monitor_cache 
callers to win32u and use the cache introduced by this series. I have 
update_monitor_cache removed in my tree and I plan to send a series 
doing that soon after this one. I just used a quick and non-invasive 
solution here for now.


Thanks,

Jacek




More information about the wine-devel mailing list