[PATCH v3] shlwapi/tests: Remove SHFormatDateTimeA() crash test.

Francois Gouget fgouget at codeweavers.com
Wed Sep 1 04:53:35 CDT 2021


SHFormatDateTimeA() crashes when given a NULL input pointer which is not
really useful to know.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
v3: Remove the test instead of documenting it. See:
https://www.winehq.org/pipermail/wine-devel/2021-September/194251.html
---
 dlls/shlwapi/tests/ordinal.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/dlls/shlwapi/tests/ordinal.c b/dlls/shlwapi/tests/ordinal.c
index bf43d35b1c2..0284800e10f 100644
--- a/dlls/shlwapi/tests/ordinal.c
+++ b/dlls/shlwapi/tests/ordinal.c
@@ -1674,12 +1674,6 @@ static void test_SHFormatDateTimeA(void)
     DWORD flags;
     INT ret;
 
-if (0)
-{
-    /* crashes on native */
-    pSHFormatDateTimeA(NULL, NULL, NULL, 0);
-}
-
     GetLocalTime(&st);
     SystemTimeToFileTime(&st, &filetime);
     /* SHFormatDateTime expects input as utc */
-- 
2.30.2



More information about the wine-devel mailing list