[PATCH 2/2 resent] ws2_32: Add tests for exclusive flag for IOCTL_AFD_POLL.

[Guillaume Charifi-Hoareau]

Oops sorry, I noticed your mail after I sent the patches, I'm rebasing and resending

Le jeudi 2 septembre 2021, 23:29:55 CEST Zebediah Figura (she/her) a écrit :
> Wow. That is some of the bizarrest behaviour I've seen. I'd call it a
> bug, but I can't even figure out what behaviour they were *trying* to
> implement.

Well you know... windows being a bug per se... ¯\_(ツ)_/¯

> 
> I kept reading through your test, trying to describe the behaviour in
> simpler (or saner) terms, and failing. So congratulations, I think
> you've hit the nail on the head :D

Thank you that's kind! :)

> Yeah, that looks about right, nothing else comes to mind now.
> 
> In terms of some informal review on those, I saw that one and the one
> with the comments changed. I think in both cases the comments are kind
> of redundant—reading the code tells me as much and is actually kind of
> easier. Where comments could help (and the way I usually tend to write
> them) is in listing the conclusions that each following chunk of code
> actually proves. That's a bit vague, but I think it would help make the
> tests make sense a bit more readily.

Ok, I'll add some explanatory notes.

> 
> Also, a nitpick—there's a C99 variable declaration in the for loop
> initializer; unfortunately we have to avoid those.

Oops, fixing!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210903/8b9131c6/attachment.htm>