[PATCH 3/3] wininet: InternetErrorDlg(FLAGS_ERROR_UI_FILTER_FOR_ERRORS) should return ERROR_SUCCESS instead of ERROR_CANCELLED.
Jacek Caban
jacek at codeweavers.com
Mon Sep 6 08:31:09 CDT 2021
On 9/1/21 4:13 PM, Dmitry Timoshkov wrote:
> default:
> - res = ERROR_CANCELLED;
> + res = (dwFlags & FLAGS_ERROR_UI_FILTER_FOR_ERRORS) ? ERROR_SUCCESS : ERROR_CANCELLED;
> + break;
This essentially changes Wine behaviour from less permissive than native
to more permissive and I'm not sure that a good thing in this case.
Given that support for FLAGS_ERROR_UI_FILTER_FOR_ERRORS seems trivial
and you already have tests for them, how about filtering them instead?
Thanks,
Jacek
More information about the wine-devel
mailing list