[PATCH 0/6] DbgHelp: Reworked line handling APIs (v2)
Eric Pouech
eric.pouech at gmail.com
Tue Sep 7 02:26:29 CDT 2021
Basically, current implem line management is broken:
- in some code paths, same buffer is used both as input and output
this serie fixes it by putting in place a cleaner way of setting
the returned buffer
it also implements a couple of missing W64 variants of APIs
(this issue had been reported by Alistair a couple of months ago on
wine-devel)
Changes in v2:
- set internal flags on line info on the fly
(use of func_normalize() was broken anyway)
A+
---
Eric Pouech (6):
dbghelp: let symt_fill_func_line_info and symt_get_func_line_next be a static function inside symbol.c
dbghelp: introducing internal_line_t structure as help in Line manipulation
dbghelp: implemented all SymGetLineNext* functions using internal_line_t
dbghelp: (re)write SymGetLinePrev* with internal_line_t
dbghelp: set is_first and is_last flags on the fly in symt_add_func_line
dbghelp: get rid of useless symt_normalize_func()
dlls/dbghelp/dbghelp.spec | 4 +-
dlls/dbghelp/dbghelp_private.h | 2 -
dlls/dbghelp/dwarf.c | 1 -
dlls/dbghelp/msc.c | 3 -
dlls/dbghelp/stabs.c | 1 -
dlls/dbghelp/symbol.c | 429 ++++++++++++++++++++-------------
6 files changed, 258 insertions(+), 182 deletions(-)
More information about the wine-devel
mailing list