[PATCH] wined3d: Handle null semantics in stream output description cache.

Henri Verbeet hverbeet at gmail.com
Thu Sep 9 10:46:25 CDT 2021


On Mon, 6 Sept 2021 at 13:54, Nikolay Sivov <nsivov at codeweavers.com> wrote:
> +        if (!!a->semantic_name ^ !!b->semantic_name)
> +            return a->semantic_name ? -1 : 1;

I suppose that's fine, although "if (!a->semantic_name !=
!b->semantic_name)" would work just as well. Alternatively, we could
do something like

    if ((ret = (!a->semantic_name - !b->semantic_name)))
        return ret;

which would perhaps better fit the rest of the function.



More information about the wine-devel mailing list