[PATCH 1/8] dinput8/tests: Fix inverted winetest_win_skip condition.

Rémi Bernon rbernon at codeweavers.com
Mon Sep 13 03:48:52 CDT 2021


And change skipped test message. It's not really useful and it will fail
the tests if the main test summary doesn't match the number of skipped
messages.

Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---

In order for the skipped tests to be counted correctly we would need a
new winetest_add_skipped helper in wine/test.h and that would cause all
tests to be rebuilt.

This is simpler and I don't think driver skipped test count matter so
much. It could also be added later.

 dlls/dinput8/tests/driver_hid.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/dinput8/tests/driver_hid.h b/dlls/dinput8/tests/driver_hid.h
index 8fad343157d..42d12a0cf27 100644
--- a/dlls/dinput8/tests/driver_hid.h
+++ b/dlls/dinput8/tests/driver_hid.h
@@ -326,7 +326,7 @@ static inline void winetest_vskip( const char *msg, __ms_va_list args )
 {
     if (winetest_add_line() < winetest_mute_threshold)
     {
-        winetest_print_context( "Tests skipped: " );
+        winetest_print_context( "Driver tests skipped: " );
         kvprintf( msg, args );
         InterlockedIncrement( &skipped );
     }
@@ -347,7 +347,7 @@ static inline void WINAPIV winetest_win_skip( const char *msg, ... )
 {
     __ms_va_list args;
     __ms_va_start( args, msg );
-    if (running_under_wine) winetest_vskip( msg, args );
+    if (!running_under_wine) winetest_vskip( msg, args );
     else winetest_vok( 0, msg, args );
     __ms_va_end( args );
 }
-- 
2.33.0




More information about the wine-devel mailing list