[PATCH 1/4] winexinput.sys: Register known XBox controllers hardware ids.
Rémi Bernon
rbernon at codeweavers.com
Mon Sep 13 04:24:56 CDT 2021
I'm not completely sure to see what's wrong with these patches but I'm
going to assume that it wasn't great to have a hardcoded VID&PID list
from the beginning and that it would be better to use a good heuristic
instead.
The axis and button count heuristic should cover the XBox gamepad list,
but I don't think it's good, as it will match any joystick with a lot of
axes and buttons, although they may not be gamepads.
It could also be interesting to have some user-facing configurable
settings so we can force or prevent some devices to be seen by XInput
(and use DInput instead).
I'll just keep the is_xbox_gamepad helper for now, and resend something
later. What I wanted to move to winexinput was actually more the custom
product strings rather than this helper.
--
Rémi Bernon <rbernon at codeweavers.com>
More information about the wine-devel
mailing list