[PATCH] msi: Don't leak the file handle on error in cabinet_close_file_info().
Hans Leidekker
hans at codeweavers.com
Mon Sep 13 05:05:00 CDT 2021
Signed-off-by: Hans Leidekker <hans at codeweavers.com>
---
dlls/msi/media.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/dlls/msi/media.c b/dlls/msi/media.c
index cc4648481ba..af6e83b893e 100644
--- a/dlls/msi/media.c
+++ b/dlls/msi/media.c
@@ -507,16 +507,23 @@ static INT_PTR cabinet_close_file_info(FDINOTIFICATIONTYPE fdint,
data->mi->is_continuous = FALSE;
if (!DosDateTimeToFileTime(pfdin->date, pfdin->time, &ft))
+ {
+ CloseHandle(handle);
return -1;
+ }
if (!LocalFileTimeToFileTime(&ft, &ftLocal))
+ {
+ CloseHandle(handle);
return -1;
+ }
if (!SetFileTime(handle, &ftLocal, 0, &ftLocal))
+ {
+ CloseHandle(handle);
return -1;
+ }
CloseHandle(handle);
-
- data->cb(data->package, data->curfile, MSICABEXTRACT_FILEEXTRACTED, NULL, NULL,
- data->user);
+ data->cb(data->package, data->curfile, MSICABEXTRACT_FILEEXTRACTED, NULL, NULL, data->user);
msi_free(data->curfile);
data->curfile = NULL;
--
2.30.2
More information about the wine-devel
mailing list