[PATCH v2 3/3] msvcrt: Add an SSE2 memset_aligned_32 implementation.

Rémi Bernon rbernon at codeweavers.com
Tue Sep 14 05:55:53 CDT 2021


On 9/14/21 12:15 PM, Marvin wrote:
> Hi,
> 
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> 
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=97908
> 
> Your paranoid android.
> 
> 
> === debiant2 (build log) ===
> 
> ../wine/dlls/msvcrt/string.c:2872:9: error: the register ‘xmm0’ cannot be clobbered in ‘asm’ for the current target
> Task: The win32 Wine build failed
> 
> === debiant2 (build log) ===
> 
> ../wine/dlls/msvcrt/string.c:2872:9: error: the register ‘xmm0’ cannot be clobbered in ‘asm’ for the current target
> Task: The wow32 Wine build failed
> 

Interesting...

I guess we can either:

* guard it with #ifdef __SSE2__, and in that case now that we import 
x86intrin.h we could use intel intrinsics instead of inline assembly,

* or make it an external assembly function.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list