[PATCH 2/2] winemac.drv: Remove now-unnecessary drag stop event on mouse up

Tim Clem tclem at codeweavers.com
Tue Sep 14 15:22:46 CDT 2021


This approach was added by 5cf64084fb6 to work around changes to
event behavior in macOS Catalina, 10.15. However, more reliable
notification center messages for dragging are available on 10.12+,
making this path unnecessary.

Signed-off-by: Tim Clem <tclem at codeweavers.com>
---
 dlls/winemac.drv/cocoa_app.m | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/dlls/winemac.drv/cocoa_app.m b/dlls/winemac.drv/cocoa_app.m
index fe10ee8c41d..2d18da7f99a 100644
--- a/dlls/winemac.drv/cocoa_app.m
+++ b/dlls/winemac.drv/cocoa_app.m
@@ -1747,14 +1747,6 @@ - (void) handleMouseButton:(NSEvent*)theEvent
         WineWindow* windowBroughtForward = nil;
         BOOL process = FALSE;
 
-        if (!useDragNotifications &&
-            type == NSEventTypeLeftMouseUp &&
-            [windowsBeingDragged count] &&
-            [window isKindOfClass:[WineWindow class]])
-        {
-            [self handleWindowDrag:window begin:NO];
-        }
-
         if ([window isKindOfClass:[WineWindow class]] &&
             type == NSEventTypeLeftMouseDown &&
             ![theEvent wine_commandKeyDown])
-- 
2.32.0




More information about the wine-devel mailing list