[PATCH v3 2/2] ntdll: Use the F_PREALLOCATE fcntl(2) on Mac OS when posix_fallocate(2/3) isn't available.

Chip Davis cdavis at codeweavers.com
Wed Sep 15 11:42:17 CDT 2021


September 15, 2021 4:39 AM, "Alexandre Julliard" <julliard at winehq.org> wrote:

> Huw Davies <huw at codeweavers.com> writes:
> 
>> On Wed, Sep 15, 2021 at 10:52:35AM +0200, Alexandre Julliard wrote:
>>> Do we actually need this in the first place? I thought posix_fallocate()
>>> was supposed to be the portable solution <g>
>> 
>> It's not available on macOS (at least not on 10.14), so apparently
>> it's not that portable ;-/
> 
> I'd suggest to ignore it then. It's only an optimization, and
> F_PREALLOCATE doesn't seem like a good match for this.

Honestly, I only wrote this one to shut up the FIXME that gets emitted
every time Steam installs something. Maybe demoting it to a WARN is
more apropos, then.

Now if you'll excuse me, I'm off to beg Apple once again for a new feature...

Chip



More information about the wine-devel mailing list